Skip to content

docs: fix rustchain tip bot source link#5588

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
iamdinhthuan:docs-fix-tip-bot-link
May 18, 2026
Merged

docs: fix rustchain tip bot source link#5588
Scottcjn merged 1 commit into
Scottcjn:mainfrom
iamdinhthuan:docs-fix-tip-bot-link

Conversation

@iamdinhthuan
Copy link
Copy Markdown
Contributor

Summary

  • replace the dead https://github.com/mtarcure/rustchain-tip-bot references with the live RustChain monorepo path
  • update the setup copy command to use the files that live under integrations/rustchain-bounties
  • add a regression assertion so generated bot comments keep linking to the current source

Validation

  • old URL: https://github.com/mtarcure/rustchain-tip-bot -> HTTP 404
  • new URL: https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bounties -> HTTP 200
  • python3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/auth.py integrations/rustchain-bounties/state.py integrations/rustchain-bounties/test_tip_bot.py
  • python3 -m pytest integrations/rustchain-bounties/test_tip_bot.py -q -> 64 passed
  • git diff --check -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.py
  • python3 tools/bcos_spdx_check.py --base-ref origin/main -> BCOS SPDX check: OK

Duplicate check

@github-actions
Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/S PR: 11-50 lines labels May 17, 2026
Copy link
Copy Markdown

@ZacharyZhang-NY ZacharyZhang-NY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR #5588 at head 20a0226.

This is a focused fix for stale rustchain-tip-bot source links. The old standalone repository URL is dead, and the replacement points to the live RustChain monorepo integration path. The README setup instructions now copy the files that actually exist under integrations/rustchain-bounties, and the new regression covers all generated bot comment footers.

Validation run:

  • curl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/mtarcure/rustchain-tip-bot -> 404 https://github.com/mtarcure/rustchain-tip-bot
  • curl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bounties -> 200 https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bounties
  • python3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/auth.py integrations/rustchain-bounties/state.py integrations/rustchain-bounties/test_tip_bot.py -> passed
  • python3 -B -m pytest integrations/rustchain-bounties/test_tip_bot.py -q -> 64 passed
  • git diff --check origin/main...HEAD -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.py -> passed
  • python3 tools/bcos_spdx_check.py --base-ref origin/main -> BCOS SPDX check: OK

I found no blocker in this scoped documentation/comment-link fix.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR. 🚀

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown

@TJCurnutte TJCurnutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is a narrow source-link fix with useful regression coverage.

Validation I ran on head 20a02269924860e6913324bfb19c5651faff79c2:

  • git diff --check origin/main...HEAD -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.py passed.
  • python3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.py passed.
  • PYTHONPATH=integrations/rustchain-bounties python3 -B -m pytest -q integrations/rustchain-bounties/test_tip_bot.py passed with 64 passed, 1 warning in 0.26s.
  • The new target path exists in the live RustChain repo contents API (tip_bot.py, tip_bot_action.py, and README.md present under integrations/rustchain-bounties).
  • The old mtarcure/rustchain-tip-bot repository lookup returns HTTP 404, and the changed README/source no longer emit that URL; the only remaining test-side occurrence is the negative assertion constant.

The generated success/failure/duplicate/unauthorized comment footers now point users back to the in-repo RustChain implementation instead of a dead external source, and the setup copy command references files that are actually present in this directory.

Copy link
Copy Markdown
Contributor

@kekehanshujun kekehanshujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the tip-bot source link update. The replacement path points at the in-repo integrations/rustchain-bounties directory, which contains the referenced source files, and the tests cover all generated comment footers to prevent the old external repo URL from returning.

I do not see a blocker in this patch.

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Scottcjn Scottcjn merged commit 545c225 into Scottcjn:main May 18, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation size/S PR: 11-50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants