docs: fix rustchain tip bot source link#5588
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
ZacharyZhang-NY
left a comment
There was a problem hiding this comment.
Approved PR #5588 at head 20a0226.
This is a focused fix for stale rustchain-tip-bot source links. The old standalone repository URL is dead, and the replacement points to the live RustChain monorepo integration path. The README setup instructions now copy the files that actually exist under integrations/rustchain-bounties, and the new regression covers all generated bot comment footers.
Validation run:
curl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/mtarcure/rustchain-tip-bot->404 https://github.com/mtarcure/rustchain-tip-botcurl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bounties->200 https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bountiespython3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/auth.py integrations/rustchain-bounties/state.py integrations/rustchain-bounties/test_tip_bot.py-> passedpython3 -B -m pytest integrations/rustchain-bounties/test_tip_bot.py -q-> 64 passedgit diff --check origin/main...HEAD -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.py-> passedpython3 tools/bcos_spdx_check.py --base-ref origin/main-> BCOS SPDX check: OK
I found no blocker in this scoped documentation/comment-link fix.
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
TJCurnutte
left a comment
There was a problem hiding this comment.
Approved. This is a narrow source-link fix with useful regression coverage.
Validation I ran on head 20a02269924860e6913324bfb19c5651faff79c2:
git diff --check origin/main...HEAD -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.pypassed.python3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.pypassed.PYTHONPATH=integrations/rustchain-bounties python3 -B -m pytest -q integrations/rustchain-bounties/test_tip_bot.pypassed with64 passed, 1 warning in 0.26s.- The new target path exists in the live RustChain repo contents API (
tip_bot.py,tip_bot_action.py, andREADME.mdpresent underintegrations/rustchain-bounties). - The old
mtarcure/rustchain-tip-botrepository lookup returnsHTTP 404, and the changed README/source no longer emit that URL; the only remaining test-side occurrence is the negative assertion constant.
The generated success/failure/duplicate/unauthorized comment footers now point users back to the in-repo RustChain implementation instead of a dead external source, and the setup copy command references files that are actually present in this directory.
kekehanshujun
left a comment
There was a problem hiding this comment.
I reviewed the tip-bot source link update. The replacement path points at the in-repo integrations/rustchain-bounties directory, which contains the referenced source files, and the tests cover all generated comment footers to prevent the old external repo URL from returning.
I do not see a blocker in this patch.
Summary
https://github.com/mtarcure/rustchain-tip-botreferences with the live RustChain monorepo pathintegrations/rustchain-bountiesValidation
https://github.com/mtarcure/rustchain-tip-bot-> HTTP 404https://github.com/Scottcjn/Rustchain/tree/main/integrations/rustchain-bounties-> HTTP 200python3 -B -m py_compile integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/auth.py integrations/rustchain-bounties/state.py integrations/rustchain-bounties/test_tip_bot.pypython3 -m pytest integrations/rustchain-bounties/test_tip_bot.py -q-> 64 passedgit diff --check -- integrations/rustchain-bounties/README.md integrations/rustchain-bounties/tip_bot.py integrations/rustchain-bounties/test_tip_bot.pypython3 tools/bcos_spdx_check.py --base-ref origin/main-> BCOS SPDX check: OKDuplicate check
mtarcure,rustchain-tip-bot, andintegrations/rustchain-bounties; no prior report found