distributed-chat: add chat history sharing preference and restrict protocol responses

Author: jolavillette

src/chat/distributedchat.cc

@@ -66,6 +66,7 @@ DistributedChatService::DistributedChatService(uint32_t serv_type,p3ServiceContr
 {
     _time_shift_average = 0.0f ;
     _should_reset_lobby_counts = false ;
+    _allow_history_sharing = false ;
     last_visible_lobby_info_request_time = 0 ;
 }
 
@@ -2149,6 +2150,15 @@ void DistributedChatService::addToSaveList(std::list<RsItem*>& list) const
 		list.push_back(vitem);
 	}
 
+	/* Save Allow History Sharing */
+	{
+		RsConfigKeyValueSet *vitem = new RsConfigKeyValueSet ;
+		RsTlvKeyValue kv;
+		kv.key = "ALLOW_HISTORY_SHARING";
+		kv.value = _allow_history_sharing ? "1" : "0";
+		vitem->tlvkvs.pairs.push_back(kv);
+		list.push_back(vitem);
+	}
 }
 
 bool DistributedChatService::processLoadListItem(const RsItem *item)
@@ -2174,6 +2184,12 @@ bool DistributedChatService::processLoadListItem(const RsItem *item)
 				return true;
 			}
 
+			if( kit->key == "ALLOW_HISTORY_SHARING" )
+			{
+				_allow_history_sharing = (kit->value == "1") ;
+				return true;
+			}
+
 			if( kit->key.compare(0, strldID.length(), strldID) == 0)
 			{
 #ifdef DEBUG_CHAT_LOBBIES
@@ -2324,6 +2340,13 @@ void DistributedChatService::handleRecvLobbyHistoryProbe(RsChatLobbyHistoryProbe
 		}
 	}
 
+	// Check if we allow sharing history
+	if(!_allow_history_sharing)
+	{
+		std::cerr << "handleRecvLobbyHistoryProbe(): history sharing is disabled. Ignoring." << std::endl;
+		return ;
+	}
+
 	// Retrieve our local history for this lobby
 	std::list<HistoryMsg> msgs ;
 	mHistMgr->getMessages(ChatId(item->lobby_id), msgs, 0) ; // 0 = get all available
@@ -2408,6 +2431,13 @@ void DistributedChatService::handleRecvLobbyHistoryRequest(RsChatLobbyHistoryReq
 		}
 	}
 
+	// Check if we allow sharing history
+	if(!_allow_history_sharing)
+	{
+		std::cerr << "handleRecvLobbyHistoryRequest(): history sharing is disabled. Ignoring." << std::endl;
+		return ;
+	}
+
 	// Retrieve local history
 	std::list<HistoryMsg> msgs ;
 	mHistMgr->getMessages(ChatId(item->lobby_id), msgs, item->max_count) ;

src/chat/distributedchat.h

@@ -87,6 +87,8 @@ class DistributedChatService
 		// Lobby history retrieval protocol
 		bool requestLobbyHistory(const ChatLobbyId& lobby_id) ;
 		bool requestLobbyHistoryFromPeer(const ChatLobbyId& lobby_id, const RsPeerId& peer_id, uint32_t max_count, uint32_t oldest_ts) ;
+		void allowHistorySharing(bool allow) { _allow_history_sharing = allow; triggerConfigSave(); }
+		bool isHistorySharingAllowed() const { return _allow_history_sharing; }
 
 	protected:
 		bool handleRecvItem(RsChatItem *) ;
@@ -171,6 +173,7 @@ class DistributedChatService
 		rstime_t last_lobby_challenge_time ; 					// prevents bruteforce attack
 		rstime_t last_visible_lobby_info_request_time ;	// allows to ask for updates
 		bool _should_reset_lobby_counts ;
+		bool _allow_history_sharing ;
 		RsGxsId _default_identity;
 		std::map<ChatLobbyId,RsGxsId> _lobby_default_identity;
 

src/chat/p3chatservice.cc

@@ -564,6 +564,17 @@ bool p3ChatService::requestLobbyHistoryFromPeer(const ChatLobbyId& lobby_id, con
     return DistributedChatService::requestLobbyHistoryFromPeer(lobby_id, peer_id, max_count, oldest_ts) ;
 }
 
+bool p3ChatService::allowHistorySharing(bool allow)
+{
+    DistributedChatService::allowHistorySharing(allow) ;
+    return true ;
+}
+
+bool p3ChatService::isHistorySharingAllowed() const
+{
+    return DistributedChatService::isHistorySharingAllowed() ;
+}
+
 
 void p3ChatService::sendChatItem(RsChatItem *item)
 {

src/chat/p3chatservice.h

@@ -141,6 +141,9 @@ class p3ChatService :
     virtual bool requestLobbyHistory(const ChatLobbyId& lobby_id) override;
     virtual bool requestLobbyHistoryFromPeer(const ChatLobbyId& lobby_id, const RsPeerId& peer_id, uint32_t max_count, uint32_t oldest_ts) override;
 
+    virtual bool allowHistorySharing(bool allow) override;
+    virtual bool isHistorySharingAllowed() const override;
+
     /** methods that will call the DistantChatService parent
      */
     virtual bool setDistantChatPermissionFlags(uint32_t flags) override;

src/retroshare/rschats.h

@@ -634,6 +634,19 @@ class RsChats
      */
     virtual bool requestLobbyHistoryFromPeer(const ChatLobbyId& lobby_id, const RsPeerId& peer_id, uint32_t max_count, uint32_t oldest_ts) = 0 ;
 
+    /**
+     * @brief allowHistorySharing enable or disable sharing of chat history with friends
+     * @param[in] allow set to true to allow sharing, false to disallow
+     * @return true on success
+     */
+    virtual bool allowHistorySharing(bool allow) = 0 ;
+
+    /**
+     * @brief isHistorySharingAllowed check if history sharing is allowed
+     * @return true if sharing is allowed, false otherwise
+     */
+    virtual bool isHistorySharingAllowed() const = 0 ;
+
     /**
      * @brief createChatLobby create a new chat lobby
      * @jsonapi{development}