If communication_key already exists it skips keypair generation, but it still calls config.write() at line 32 which overwrites the config file. If the config has groups with key shares, those are preserved only because it reads and re-writes the whole config. But there's no confirmation prompt, no backup, and no warning that groups/shares exist. A user running init on a config with active key shares gets no warning.
src/cli/init.rs:20-26 — skips keypair but still writessrc/cli/init.rs:32 — unconditional config.write()
Originally created in: https://github.com/Nori-zk/mina-multi-sig-example/blob/main/FEEDBACK.md
If
communication_keyalready exists it skips keypair generation, but it still callsconfig.write()at line 32 which overwrites the config file. If the config has groups with key shares, those are preserved only because it reads and re-writes the whole config. But there's no confirmation prompt, no backup, and no warning that groups/shares exist. A user runninginiton a config with active key shares gets no warning.src/cli/init.rs:20-26— skips keypair but still writessrc/cli/init.rs:32— unconditionalconfig.write()Originally created in: https://github.com/Nori-zk/mina-multi-sig-example/blob/main/FEEDBACK.md