[CI] Fix llama-cli hanging in conversation mode during benchmark#2228
Merged
mhalk merged 1 commit intoMay 20, 2026
Merged
Conversation
Use -st (single-turn) and redirect stdin from /dev/null to prevent llama-cli from blocking indefinitely in auto-enabled conversation mode. Co-authored-by: Cursor <cursoragent@cursor.com>
mhalk
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
jplehr
approved these changes
May 20, 2026
jplehr
left a comment
jplehr
left a comment
Contributor
There was a problem hiding this comment.
Interesting that it does not respect /exit from what I get from this PR.
Contributor
Author
|
It was described as auto conversation mode, but I agree that this is unexpected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use -st (single-turn) and redirect stdin from /dev/null to prevent llama-cli from blocking indefinitely in auto-enabled conversation mode.
Motivation
Observed possible hangs of
llama-cliprocesses.Technical Details
The argument
single-turnshould force-exit thellama-cliprocess after the very first response.Test Plan
Test Result
Submission Checklist