Skip to content

Forward AD tests and cleanup for vector interface#436

Merged
kshyatt merged 2 commits into
mainfrom
ksh/vi
Jun 25, 2026
Merged

Forward AD tests and cleanup for vector interface#436
kshyatt merged 2 commits into
mainfrom
ksh/vi

Conversation

@kshyatt

@kshyatt kshyatt commented May 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Do you have any idea if this would make sense to implement at the VectorInterface level? Alternatively, to not necessarily mark everything as @is_primitive there but to already provide the implementation?

@kshyatt

kshyatt commented May 19, 2026

Copy link
Copy Markdown
Member Author

We could do it there if it's generic enough? I don't have a strong opinion tbh

@lkdvos

lkdvos commented May 19, 2026

Copy link
Copy Markdown
Member

It looks like all rules are implemented solely in terms of Mooncake or VectorInterface functions, so that might just work?

@kshyatt

kshyatt commented May 19, 2026

Copy link
Copy Markdown
Member Author

Nice, I can move these over tomorrow then

@kshyatt kshyatt changed the title Forward rules for vector interface Forward AD tests and cleanup for vector interface May 21, 2026
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
ext/TensorKitMooncakeExt/tangent.jl 65.06% <ø> (ø)
ext/TensorKitMooncakeExt/utility.jl 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos

lkdvos commented May 21, 2026

Copy link
Copy Markdown
Member

I think you still need the @is_primitive calls, since the VI rules are only defined for AbstractArray

@kshyatt

kshyatt commented May 21, 2026

Copy link
Copy Markdown
Member Author

Addressed by another PR over there 😉

@kshyatt kshyatt force-pushed the ksh/vi branch 2 times, most recently from 4dd9c94 to eb25bbc Compare June 1, 2026 07:35
Comment thread ext/TensorKitMooncakeExt/vectorinterface.jl
Comment thread test/mooncake/vectorinterface.jl

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think I've been annoying for long enough about the VectorInterface compat, so I think the main thing here is to just bump the VI version and drop the versions that don't have these rules, and go from here. Otherwise this PR looks ready for merging to me, thanks @kshyatt !

@kshyatt

kshyatt commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

OK the Enzyme fail is unrelated, something that intermittently didn't show up previously, I'll fix separately in the Enzyme VI PR

@kshyatt kshyatt merged commit b905c2e into main Jun 25, 2026
57 of 59 checks passed
@kshyatt kshyatt deleted the ksh/vi branch June 25, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants