Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
left a comment
There was a problem hiding this comment.
Cool! Do you have any idea if this would make sense to implement at the VectorInterface level? Alternatively, to not necessarily mark everything as @is_primitive there but to already provide the implementation?
|
We could do it there if it's generic enough? I don't have a strong opinion tbh |
|
It looks like all rules are implemented solely in terms of Mooncake or VectorInterface functions, so that might just work? |
|
Nice, I can move these over tomorrow then |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
I think you still need the |
|
Addressed by another PR over there 😉 |
4dd9c94 to
eb25bbc
Compare
lkdvos
left a comment
There was a problem hiding this comment.
Alright, I think I've been annoying for long enough about the VectorInterface compat, so I think the main thing here is to just bump the VI version and drop the versions that don't have these rules, and go from here. Otherwise this PR looks ready for merging to me, thanks @kshyatt !
|
OK the Enzyme fail is unrelated, something that intermittently didn't show up previously, I'll fix separately in the Enzyme VI PR |
No description provided.