Skip to content

Commit 2b82e47

Browse files
committed
Remove categories references from reference and package tests
1 parent af19ee4 commit 2b82e47

20 files changed

Lines changed: 2 additions & 110 deletions

packages/overture-schema-cli/tests/test_heterogeneous_collections.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ def heterogeneous_collection_json() -> str:
2020
geometry_type="Point",
2121
coordinates=[0.5, 0.5],
2222
operating_status="open",
23-
categories={"primary": "restaurant"},
2423
names={"primary": "Valid Place"},
2524
)
2625
return json.dumps([building, place])
@@ -55,7 +54,6 @@ def heterogeneous_with_missing_fields_json() -> str:
5554
type="place",
5655
geometry_type="Point",
5756
coordinates=[6.5, 6.5],
58-
categories={"primary": "restaurant"},
5957
names={"primary": "Place missing required field"},
6058
)
6159
return json.dumps([building1, building2, building3, place])

packages/overture-schema-places-theme/src/overture/schema/places/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66

77
__path__ = __import__("pkgutil").extend_path(__path__, __name__)
88

9-
from .place import Address, Brand, Categories, OperatingStatus, Place
9+
from .place import Address, Brand, OperatingStatus, Place
1010

11-
__all__ = ["Address", "Brand", "Categories", "OperatingStatus", "Place"]
11+
__all__ = ["Address", "Brand", "OperatingStatus", "Place"]

packages/overture-schema-places-theme/tests/place_baseline_schema.json

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -56,34 +56,6 @@
5656
"title": "Brand",
5757
"type": "object"
5858
},
59-
"Categories": {
60-
"additionalProperties": false,
61-
"description": "Categories a place belongs to.\n\nComplete list is available on GitHub: https://github.com/OvertureMaps/schema/blob/main/docs/schema/concepts/by-theme/places/overture_categories.csv",
62-
"properties": {
63-
"alternate": {
64-
"description": "Alternate categories of the place.\n\nSome places might fit into two categories, e.g., a book store and a coffee shop. In\nthese cases, the primary category can be augmented with additional categories.",
65-
"items": {
66-
"description": "Category in snake_case format",
67-
"pattern": "^[a-z0-9]+(_[a-z0-9]+)*$",
68-
"type": "string"
69-
},
70-
"title": "Alternate",
71-
"type": "array",
72-
"uniqueItems": true
73-
},
74-
"primary": {
75-
"description": "The primary or main category of the place.",
76-
"pattern": "^[a-z0-9]+(_[a-z0-9]+)*$",
77-
"title": "Primary",
78-
"type": "string"
79-
}
80-
},
81-
"required": [
82-
"primary"
83-
],
84-
"title": "Categories",
85-
"type": "object"
86-
},
8759
"NameRule": {
8860
"additionalProperties": false,
8961
"description": "A rule that can be evaluated to determine the name in advanced scenarios.\n\nName rules are used for cases where the primary name is not sufficient; the common name is not\nthe right fit for the use case and another variant is needed; or where the name only applies in\ncertain specific circumstances.\n\nExamples might include:\n- An official, alternate, or short name.\n- A name that only applies to part of a linear path like a road segment (geometric range\n scoping).\n- A name that only applies to the left or right side of a linear path like a road segment (side\n scoping).\n- A name that is only accepted by some political perspectives.",
@@ -428,9 +400,6 @@
428400
"$ref": "#/$defs/Brand",
429401
"description": "The brand associated with the place."
430402
},
431-
"categories": {
432-
"$ref": "#/$defs/Categories"
433-
},
434403
"confidence": {
435404
"description": "A score between 0 and 1 indicating how confident we are that the place exists.\n\nA confidence score of 0 indicates that we are certain the place doesn't exist\nanymore and will always be paired with an `operating_status` of\n`\"permanently_closed\"`.\n\nA confidence score of 1 indicates that we are certain the place does exist.\n\nIf there is no value for confidence, it means we don't have enough information on\nwhich to estimate our confidence level.",
436405
"maximum": 1.0,

reference/counterexamples/places/bad-address-invalid-property.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ properties:
1212
version: 0
1313
names:
1414
primary: Fancy POI with invalid address property (region2)
15-
categories:
16-
primary: some_category
1715
addresses:
1816
- freeform: "770 Broadway, Floor 8"
1917
locality: "New York"

reference/counterexamples/places/bad-categories-missing-primary.yaml

Lines changed: 0 additions & 16 deletions
This file was deleted.

reference/counterexamples/places/bad-categories-value.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

reference/counterexamples/places/bad-empty-emails.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ geometry:
55
type: Point
66
coordinates: [0, 0]
77
properties:
8-
categories:
9-
primary: some_category
108
confidence: 0.9
119
websites:
1210
- https://www.example.com

reference/counterexamples/places/bad-empty-phones.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ geometry:
55
type: Point
66
coordinates: [0, 0]
77
properties:
8-
categories:
9-
primary: some_category
108
confidence: 0.9
119
websites:
1210
- https://www.example.com

reference/counterexamples/places/bad-empty-socials.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ geometry:
55
type: Point
66
coordinates: [0, 0]
77
properties:
8-
categories:
9-
primary: some_category
108
confidence: 0.9
119
websites:
1210
- https://www.example.com

reference/counterexamples/places/bad-empty-websites.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ geometry:
55
type: Point
66
coordinates: [0, 0]
77
properties:
8-
categories:
9-
primary: some_category
108
confidence: 0.9
119
websites: []
1210
emails:

0 commit comments

Comments
 (0)