Skip to content

Commit 23cafc2

Browse files
JonCanningMelbourneDeveloper
JonCanning
and
MelbourneDeveloper
authored
Add mise task discovery support (#11)
## Summary - Discover tasks from `mise.toml`, `.mise.toml`, `mise.yaml`, and `.mise.yaml` config files - Fix TOML parser to recognize `[tasks.name]` sections without requiring a bare `[tasks]` preamble (matching real-world mise configs) - Extract pure parsers into `parsers/miseParser.ts` for testability ## Test plan - [x] Unit tests for TOML parsing (with/without preamble, descriptions, interspersed sections, empty) - [x] Unit tests for YAML parsing (task names, descriptions, empty) - [ ] E2E: open workspace with `mise.toml` containing tasks, verify they appear in CommandTree view --------- Co-authored-by: Christian Findlay <16697547+MelbourneDeveloper@users.noreply.github.com>
1 parent e665ba0 commit 23cafc2

File tree

23 files changed

+1630
-189
lines changed

23 files changed

+1630
-189
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,23 @@ jobs:
1717

1818
- run: npm ci
1919

20-
- name: Format check
21-
run: npm run format:check
20+
- name: Format
21+
run: make format
2222

2323
- name: Lint
24-
run: npm run lint
24+
run: make lint
2525

2626
- name: Spell check
27-
uses: streetsidesoftware/cspell-action@v6
28-
with:
29-
files: "src/**/*.ts"
27+
run: make spellcheck
3028

3129
- name: Build
32-
run: npm run compile
33-
34-
- name: Unit tests
35-
run: npm run test:unit
30+
run: make build
3631

37-
- name: E2E tests with coverage
38-
run: xvfb-run -a npx vscode-test --coverage --grep @exclude-ci --invert
32+
- name: Test
33+
run: make test EXCLUDE_CI=true
3934

40-
- name: Coverage threshold (90%)
41-
run: npm run coverage:check
35+
- name: Package
36+
run: make package
4237

4338
website:
4439
runs-on: ubuntu-latest

‎.vscode-test.mjs‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export default defineConfig({
1919
version: 'stable',
2020
workspaceFolder: testWorkspace,
2121
extensionDevelopmentPath: './',
22+
srcDir: __dirname,
2223
mocha: {
2324
ui: 'tdd',
2425
timeout: 60000,
@@ -31,12 +32,16 @@ export default defineConfig({
3132
]
3233
}],
3334
coverage: {
34-
include: ['out/**/*.js'],
35+
includeAll: true,
36+
// @vscode/test-cli sets report.exclude.relativePath = false, which
37+
// makes test-exclude match against absolute paths. Patterns must
38+
// start with **/ so minimatch can match any prefix.
39+
include: ['**/out/**/*.js'],
3540
exclude: [
36-
'out/test/**/*.js',
37-
'out/semantic/summariser.js', // requires Copilot auth, not available in CI
38-
'out/semantic/summaryPipeline.js', // requires Copilot auth, not available in CI
39-
'out/semantic/vscodeAdapters.js', // requires Copilot auth, not available in CI
41+
'**/out/test/**',
42+
'**/out/semantic/summariser.js', // requires Copilot auth, not available in CI
43+
'**/out/semantic/summaryPipeline.js', // requires Copilot auth, not available in CI
44+
'**/out/semantic/vscodeAdapters.js', // requires Copilot auth, not available in CI
4045
],
4146
reporter: ['text', 'lcov', 'html', 'json-summary'],
4247
output: './coverage'

‎.vscodeignore‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ test-fixtures/**
66
out/test/**
77
node_modules/**
88
!node_modules/node-sqlite3-wasm/**
9-
scripts/**
9+
tools/**
1010
.too_many_cooks/**
1111
.claude/**
1212
.github/**

‎CONTRIBUTING.md‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Contributing to CommandTree
2+
3+
## Prerequisites
4+
5+
- Node.js (LTS)
6+
- VS Code
7+
8+
## Setup
9+
10+
```bash
11+
npm install
12+
```
13+
14+
## CI Gate
15+
16+
Before submitting a pull request, you **must** run:
17+
18+
```bash
19+
make ci
20+
```
21+
22+
This runs formatting, linting, building, testing (with coverage check), and packaging. All steps must pass. Pull requests that fail `make ci` will not be merged.
23+
24+
## Make Targets
25+
26+
| Target | Description |
27+
|--------|-------------|
28+
| `make format` | Format source with Prettier |
29+
| `make lint` | Lint with ESLint |
30+
| `make build` | Compile TypeScript |
31+
| `make test` | Run unit tests, e2e tests with coverage, and coverage threshold check |
32+
| `make package` | Build VSIX package |
33+
| `make ci` | Run all of the above in sequence |
34+
35+
## Coverage
36+
37+
Tests enforce a 90% coverage threshold on lines, functions, branches, and statements. The coverage check runs automatically as part of `make test`.

‎Claude.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# CLAUDE.md - CommandTree Extension
22

3+
⚠️ CRITICAL: **Reduce token usage.** Check file size before loading. Write less. Delete fluff and dead code. Alert user when context is loaded with pointless files. ⚠️
4+
35
## Too Many Cooks
46

57
You are working with many other agents. Make sure there is effective cooperation

‎Makefile‎

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,37 @@
1-
.PHONY: format lint build package test test-exclude-ci ci
1+
.PHONY: format lint spellcheck build package test ci
22

33
format:
44
npx prettier --write "src/**/*.ts"
55

66
lint:
77
npx eslint src
88

9+
spellcheck:
10+
npx cspell "src/**/*.ts"
11+
912
build:
1013
npx tsc -p ./
1114

1215
package: build
1316
npx vsce package
1417

15-
test: build
16-
npm run test:unit
17-
npx vscode-test --coverage
18+
UNAME := $(shell uname)
19+
EXCLUDE_CI ?= false
1820

19-
test-exclude-ci: build
21+
VSCODE_TEST_CMD = npx vscode-test --coverage
22+
ifeq ($(EXCLUDE_CI),true)
23+
VSCODE_TEST_CMD += --grep @exclude-ci --invert
24+
endif
25+
26+
ifeq ($(UNAME),Linux)
27+
VSCODE_TEST = xvfb-run -a $(VSCODE_TEST_CMD)
28+
else
29+
VSCODE_TEST = $(VSCODE_TEST_CMD)
30+
endif
31+
32+
test: build
2033
npm run test:unit
21-
npx vscode-test --coverage --grep @exclude-ci --invert
34+
$(VSCODE_TEST)
35+
node tools/check-coverage.mjs
2236

23-
ci: format lint build test package
37+
ci: format lint spellcheck build test package

‎README.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ Open a workspace and the CommandTree panel appears in the sidebar. All discovere
8383
| `commandtree.excludePatterns` | Glob patterns to exclude from discovery | `**/node_modules/**`, `**/.git/**`, etc. |
8484
| `commandtree.sortOrder` | Sort commands by `folder`, `name`, or `type` | `folder` |
8585

86+
## Contributing
87+
88+
See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup and guidelines. All pull requests must pass `make ci` before merging.
89+
8690
## License
8791

8892
[MIT](LICENSE)

‎coverage-thresholds.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"lines": 81.38,
3+
"functions": 81.41,
4+
"branches": 68.17,
5+
"statements": 81.38
6+
}

‎cspell.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@
7171
"visioncortex",
7272
"behaviour",
7373
"docstrings",
74+
"golangci",
75+
"gotestsum",
7476
"subproject"
7577
]
7678
}

‎dotnet-tools.json‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"version": 1,
3+
"isRoot": true,
4+
"tools": {
5+
"csharpier": {
6+
"version": "1.2.6",
7+
"commands": [
8+
"csharpier"
9+
],
10+
"rollForward": false
11+
}
12+
}
13+
}

0 commit comments

Comments
 (0)