Skip to content

showCredits option entirely useless #189

@ilyvion

Description

@ilyvion

Because of this logic

if (this.imgBefore.credit || this.imgAfter.credit) {
this.options.showCredits = true;
} else {
this.options.showCredits = false;
}

which takes place after options are copied into this.options, it doesn't matter whether you pass showCredits in options or not, the only thing that matters is whether or not the images arguments have credit values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions