From 6e64e4aff7643d7be3b3e1c7e1e4b142ae1a75b9 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Wed, 20 May 2026 16:15:20 -0400 Subject: [PATCH 01/12] Fix Intel CI workflow and migrate off Intel container images updated environment variables for the intel-autotools job. --- .../github_autotools_intel_classic.yml | 26 ++++++++++++------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index f0faaf9b1f..69b5a2b9ef 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -3,6 +3,7 @@ name: Autotools build and unit testing with Intel Classic (weekly) on: schedule: - cron: '0 0 * * 0' # sundays @ midnight + push: # cancel running jobs if theres a newer push concurrency: @@ -12,16 +13,14 @@ concurrency: jobs: intel-autotools: runs-on: ubuntu-latest - container: - image: intel/oneapi-hpckit:2023.1.0-devel-ubuntu20.04 - env: - CC: mpiicc - FC: mpiifort - CFLAGS: "-I/libs/include" - FCFLAGS: "-I/libs/include -g -traceback" - LDFLAGS: "-L/libs/lib" - TEST_VERBOSE: 1 - I_MPI_FABRICS: "shm" # needed for mpi in image + env: + CC: mpiicc + FC: mpiifort + CFLAGS: "-I/libs/include" + FCFLAGS: "-I/libs/include -g -traceback" + LDFLAGS: "-L/libs/lib" + TEST_VERBOSE: 1 + I_MPI_FABRICS: "shm" # needed for mpi in image steps: - name: Cache dependencies id: cache @@ -29,6 +28,13 @@ jobs: with: path: /libs key: intel-libs + - name: Install Intel compilers & MPI + uses: NOAA-EMC/ci-install-intel-toolkit@develop + with: + install-classic: true + install-oneapi: true + install-mpi: true + mpi-wrapper-setup: classic - name: Install packages for building run: apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' From a316118bd39af558d59b40911db9d1ff66fdc7c2 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Wed, 27 May 2026 10:44:52 -0400 Subject: [PATCH 02/12] Revert "Fix Intel CI workflow and migrate off Intel container images" --- .../github_autotools_intel_classic.yml | 26 +++++++------------ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index 69b5a2b9ef..f0faaf9b1f 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -3,7 +3,6 @@ name: Autotools build and unit testing with Intel Classic (weekly) on: schedule: - cron: '0 0 * * 0' # sundays @ midnight - push: # cancel running jobs if theres a newer push concurrency: @@ -13,14 +12,16 @@ concurrency: jobs: intel-autotools: runs-on: ubuntu-latest - env: - CC: mpiicc - FC: mpiifort - CFLAGS: "-I/libs/include" - FCFLAGS: "-I/libs/include -g -traceback" - LDFLAGS: "-L/libs/lib" - TEST_VERBOSE: 1 - I_MPI_FABRICS: "shm" # needed for mpi in image + container: + image: intel/oneapi-hpckit:2023.1.0-devel-ubuntu20.04 + env: + CC: mpiicc + FC: mpiifort + CFLAGS: "-I/libs/include" + FCFLAGS: "-I/libs/include -g -traceback" + LDFLAGS: "-L/libs/lib" + TEST_VERBOSE: 1 + I_MPI_FABRICS: "shm" # needed for mpi in image steps: - name: Cache dependencies id: cache @@ -28,13 +29,6 @@ jobs: with: path: /libs key: intel-libs - - name: Install Intel compilers & MPI - uses: NOAA-EMC/ci-install-intel-toolkit@develop - with: - install-classic: true - install-oneapi: true - install-mpi: true - mpi-wrapper-setup: classic - name: Install packages for building run: apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' From 7223971a0df0980ea934b3967709312be8c2c3fa Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Wed, 27 May 2026 13:05:39 -0400 Subject: [PATCH 03/12] Fix Intel CI workflow and migrate off Intel container images --- .../github_autotools_intel_classic.yml | 28 +++++++++++-------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index f0faaf9b1f..512bbb522e 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -3,7 +3,8 @@ name: Autotools build and unit testing with Intel Classic (weekly) on: schedule: - cron: '0 0 * * 0' # sundays @ midnight - + push: + # cancel running jobs if theres a newer push concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -12,16 +13,14 @@ concurrency: jobs: intel-autotools: runs-on: ubuntu-latest - container: - image: intel/oneapi-hpckit:2023.1.0-devel-ubuntu20.04 - env: - CC: mpiicc - FC: mpiifort - CFLAGS: "-I/libs/include" - FCFLAGS: "-I/libs/include -g -traceback" - LDFLAGS: "-L/libs/lib" - TEST_VERBOSE: 1 - I_MPI_FABRICS: "shm" # needed for mpi in image + env: + CC: mpiicc + FC: mpiifort + CFLAGS: "-I/libs/include" + FCFLAGS: "-I/libs/include -g -traceback" + LDFLAGS: "-L/libs/lib" + TEST_VERBOSE: 1 + I_MPI_FABRICS: "shm" # needed for mpi in image steps: - name: Cache dependencies id: cache @@ -29,6 +28,13 @@ jobs: with: path: /libs key: intel-libs + - name: Install Intel compilers & MPI + uses: NOAA-EMC/ci-install-intel-toolkit@develop + with: + install-classic: true + install-oneapi: true + install-mpi: true + mpi-wrapper-setup: classic - name: Install packages for building run: apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' From 38de55541f128abd19aee4338ca0ecc72bb33522 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Wed, 27 May 2026 15:39:13 -0400 Subject: [PATCH 04/12] fix indentation --- .github/workflows/github_autotools_intel_classic.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index 512bbb522e..34cccb1914 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -4,7 +4,6 @@ on: schedule: - cron: '0 0 * * 0' # sundays @ midnight push: - # cancel running jobs if theres a newer push concurrency: group: ${{ github.workflow }}-${{ github.ref }} From f1e13b30d810b30bc7a404ac3f782af38199a5d6 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 1 Jun 2026 13:40:59 -0400 Subject: [PATCH 05/12] fix permissions for install packages in build --- .../workflows/github_autotools_intel_classic.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index 34cccb1914..bdfdf4761c 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -3,7 +3,7 @@ name: Autotools build and unit testing with Intel Classic (weekly) on: schedule: - cron: '0 0 * * 0' # sundays @ midnight - push: + pull_request: # cancel running jobs if theres a newer push concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -35,7 +35,7 @@ jobs: install-mpi: true mpi-wrapper-setup: classic - name: Install packages for building - run: apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev + run: sudo apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' name: Build netcdf run: | @@ -43,19 +43,19 @@ jobs: wget https://hdf-wordpress-1.s3.amazonaws.com/wp-content/uploads/manual/HDF5/HDF5_1_12_2/source/hdf5-1.12.2.tar.gz tar xf hdf5-1.12.2.tar.gz && cd hdf5-1.12.2 ./configure --prefix=/libs - make -j install && cd .. + sudo make -j install && cd .. wget https://github.com/Unidata/netcdf-c/archive/refs/tags/v4.8.1.tar.gz tar xf v4.8.1.tar.gz && cd netcdf-c-4.8.1 ./configure --prefix=/libs --enable-remote-fortran-bootstrap - make -j install + sudo make -j install # sets this here to pass embeded configure checks export LD_LIBRARY_PATH="/libs/lib:$LD_LIBRARY_PATH" - make -j -k build-netcdf-fortran - make -j install-netcdf-fortran + sudo make -j -k build-netcdf-fortran + sudo make -j install-netcdf-fortran wget https://github.com/yaml/libyaml/releases/download/0.2.5/yaml-0.2.5.tar.gz tar xf yaml-0.2.5.tar.gz && cd yaml-0.2.5 ./configure --prefix=/libs - make -j install && cd + sudo make -j install && cd - name: checkout uses: actions/checkout@v4.2.2 - name: Configure From d2fb445e47be0aff5e6770b6fbbe3bfff346016a Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 1 Jun 2026 13:57:32 -0400 Subject: [PATCH 06/12] minor fix --- .github/workflows/github_autotools_intel_classic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index bdfdf4761c..552c64d66f 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -35,7 +35,7 @@ jobs: install-mpi: true mpi-wrapper-setup: classic - name: Install packages for building - run: sudo apt-get update && apt-get install -y autoconf libtool automake zlibc zlib1g-dev + run: sudo apt-get update && sudo apt-get install -y autoconf libtool automake zlibc zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' name: Build netcdf run: | From 053ad84b4431cd3bac535f6048380481e4646910 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 1 Jun 2026 14:02:01 -0400 Subject: [PATCH 07/12] Fix package installation command --- .github/workflows/github_autotools_intel_classic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index 552c64d66f..e3ffb62989 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -35,7 +35,7 @@ jobs: install-mpi: true mpi-wrapper-setup: classic - name: Install packages for building - run: sudo apt-get update && sudo apt-get install -y autoconf libtool automake zlibc zlib1g-dev + run: sudo apt-get update && sudo apt-get install -y autoconf libtool automake zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' name: Build netcdf run: | From 032825b95270c9c070eb0b3521346f9c7cd6634b Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 1 Jun 2026 16:27:26 -0400 Subject: [PATCH 08/12] fix: add sudo --- .github/workflows/github_autotools_intel_classic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index e3ffb62989..fc7cac3376 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -39,7 +39,7 @@ jobs: - if: steps.cache.outputs.cache-hit != 'true' name: Build netcdf run: | - mkdir /libs + sudo mkdir /libs wget https://hdf-wordpress-1.s3.amazonaws.com/wp-content/uploads/manual/HDF5/HDF5_1_12_2/source/hdf5-1.12.2.tar.gz tar xf hdf5-1.12.2.tar.gz && cd hdf5-1.12.2 ./configure --prefix=/libs From ab0fa52740b26c0c14239415f93ae76a106ef6ea Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 8 Jun 2026 16:05:32 -0400 Subject: [PATCH 09/12] Add LD_LIBRARY_PATH export for library configuration --- .github/workflows/github_autotools_intel_classic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index fc7cac3376..eae986ec3a 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -46,6 +46,7 @@ jobs: sudo make -j install && cd .. wget https://github.com/Unidata/netcdf-c/archive/refs/tags/v4.8.1.tar.gz tar xf v4.8.1.tar.gz && cd netcdf-c-4.8.1 + export LD_LIBRARY_PATH="/libs/lib:$LD_LIBRARY_PATH" ./configure --prefix=/libs --enable-remote-fortran-bootstrap sudo make -j install # sets this here to pass embeded configure checks @@ -61,7 +62,6 @@ jobs: - name: Configure run: | autoreconf -if ./configure.ac - export LD_LIBRARY_PATH="/libs/lib:$LD_LIBRARY_PATH" ./configure --with-yaml - name: Compile run: make -j || make From 853e531dcdd148ebd3bc1c32d492d3b17996d76b Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 29 Jun 2026 16:13:50 -0400 Subject: [PATCH 10/12] Add debug logging for Intel compiler environment in CI --- .../github_autotools_intel_classic.yml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index eae986ec3a..bf1e2ac63c 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -31,9 +31,20 @@ jobs: uses: NOAA-EMC/ci-install-intel-toolkit@develop with: install-classic: true - install-oneapi: true + install-oneapi: false install-mpi: true mpi-wrapper-setup: classic + - name: Debug Intel compiler environment + run: | + echo "PATH=$PATH" + echo "CC=$CC" + echo "FC=$FC" + which mpiicc || true + which mpiifort || true + which icc || true + which ifort || true + mpiicc --version || true + mpiifort --version || true - name: Install packages for building run: sudo apt-get update && sudo apt-get install -y autoconf libtool automake zlib1g-dev - if: steps.cache.outputs.cache-hit != 'true' @@ -42,6 +53,12 @@ jobs: sudo mkdir /libs wget https://hdf-wordpress-1.s3.amazonaws.com/wp-content/uploads/manual/HDF5/HDF5_1_12_2/source/hdf5-1.12.2.tar.gz tar xf hdf5-1.12.2.tar.gz && cd hdf5-1.12.2 + echo "===== Debug Intel Environment =====" + echo "PATH=$PATH" + which mpiicc || true + which mpiifort || true + mpiicc --version || true + mpiifort --version || true ./configure --prefix=/libs sudo make -j install && cd .. wget https://github.com/Unidata/netcdf-c/archive/refs/tags/v4.8.1.tar.gz From 39b6fdfea62b0f1a74b1a2cead79510916741b99 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 29 Jun 2026 16:29:57 -0400 Subject: [PATCH 11/12] Update configuration for HDF5 and YAML installations --- .github/workflows/github_autotools_intel_classic.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index bf1e2ac63c..b7e8606bf6 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -53,13 +53,7 @@ jobs: sudo mkdir /libs wget https://hdf-wordpress-1.s3.amazonaws.com/wp-content/uploads/manual/HDF5/HDF5_1_12_2/source/hdf5-1.12.2.tar.gz tar xf hdf5-1.12.2.tar.gz && cd hdf5-1.12.2 - echo "===== Debug Intel Environment =====" - echo "PATH=$PATH" - which mpiicc || true - which mpiifort || true - mpiicc --version || true - mpiifort --version || true - ./configure --prefix=/libs + CC=gcc FC=gfortran ./configure --prefix=/libs sudo make -j install && cd .. wget https://github.com/Unidata/netcdf-c/archive/refs/tags/v4.8.1.tar.gz tar xf v4.8.1.tar.gz && cd netcdf-c-4.8.1 @@ -72,7 +66,7 @@ jobs: sudo make -j install-netcdf-fortran wget https://github.com/yaml/libyaml/releases/download/0.2.5/yaml-0.2.5.tar.gz tar xf yaml-0.2.5.tar.gz && cd yaml-0.2.5 - ./configure --prefix=/libs + CC=gcc ./configure --prefix=/libs sudo make -j install && cd - name: checkout uses: actions/checkout@v4.2.2 From f6a0c6467fd7c156745d713b910722bc3aa4c357 Mon Sep 17 00:00:00 2001 From: Vithika Shah <91550574+vithikashah001@users.noreply.github.com> Date: Mon, 29 Jun 2026 16:40:31 -0400 Subject: [PATCH 12/12] Specify compilers in configure command for netcdf-c --- .github/workflows/github_autotools_intel_classic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_autotools_intel_classic.yml b/.github/workflows/github_autotools_intel_classic.yml index b7e8606bf6..c7d6d683ea 100644 --- a/.github/workflows/github_autotools_intel_classic.yml +++ b/.github/workflows/github_autotools_intel_classic.yml @@ -58,7 +58,7 @@ jobs: wget https://github.com/Unidata/netcdf-c/archive/refs/tags/v4.8.1.tar.gz tar xf v4.8.1.tar.gz && cd netcdf-c-4.8.1 export LD_LIBRARY_PATH="/libs/lib:$LD_LIBRARY_PATH" - ./configure --prefix=/libs --enable-remote-fortran-bootstrap + CC=gcc FC=gfortran ./configure --prefix=/libs --enable-remote-fortran-bootstrap sudo make -j install # sets this here to pass embeded configure checks export LD_LIBRARY_PATH="/libs/lib:$LD_LIBRARY_PATH"