Skip to content

NMR- attribute JCAMP spectra to their vendor when metadata is available #1502

Description

@NishaSharma14

Describe the bug
When the sample folder only identifies the generic JCAMP exchange format, the vendor information from NMRium metadata is not being utilized, resulting in vendor-identifiable spectra being incorrectly categorized as generic JCAMP files.

To Reproduce
Steps to reproduce the behavior:

  1. Upload or process NMR data that includes JCAMP files with vendor metadata (manufacturer/vendor/title) in NMRium format
  2. Observe that files are categorized as generic JCAMP rather than being attributed to their specific vendor
  3. Check vendor statistics or file categorization
  4. See that vendor-identifiable spectra are counted incorrectly

Expected behavior
When the sample folder identifies the generic JCAMP exchange format, the system should:

  1. Check NMRium manufacturer/vendor/title metadata for vendor information
  2. Use the vendor metadata to properly attribute the spectra before settling on the JCAMP label
  3. Only label files as "Generic (JCAMP)" when no vendor metadata is available
  4. Count vendor-identifiable spectra correctly in statistics

Metadata

Metadata

Assignees

Labels

NMRiumbugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions