fix: Prevent concurrent wallet_requestSnaps requests
#3800
Merged
+64
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mutex to the
wallet_requestSnapshandler to prevent race conditions if multiple concurrent requests are sent from the same origin. Since Snaps are defined as caveats we need to merge permissions and for that we need the most up-to-date permissions-set, without this change we would be merging with stale data.Recommend reviewing this PR with whitespace diff hidden.
Note
Prevents concurrent processing of
wallet_requestSnapsthat could race when merging permissions.MutexinrequestSnaps.tsand wraps the permission/install flow inrunExclusive, using the requestoriginto serialize operationsres.errorwithin the mutex blockjest.config.jsWritten by Cursor Bugbot for commit 0e1386e. This will update automatically on new commits. Configure here.