[Bug/All] Roles allow viewing of channels that they should not

[Robocat999]

Describe the bug
When a user does not have permission to view a channel, but is given a role which is not explicitly being denied access, the channel (and category, if applicable) becomes visible in the channel selection bar on the left-hand side. Users can not actually view the contents of these channels, as the server correctly denies them access. However, this does lead to a looping reconnect (though that should be resolved by the recently merged 0843d7c). This will only occur if the role that is not being explicitly denied is a higher ranking role than the role being denied.

To Reproduce
Steps to reproduce the behavior:

1. Create two roles (or one role and use the everyone role)
2. Create a channel.
3. In the newly created channel, mark the lower ranking role as unable to view the channel.
4. Do not give or deny the view permission to the higher ranking role.
5. Give both roles to a user.
6. The user should now be able to see the channel and its parent category on the left-hand channel browsing menu.

Expected behavior
User should not see channels that they cannot access appear in their left-hand channel menu.

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Firefox
• Browser Version: 148.0

[anotherdoesnm]

i only saw hidden channels in autocomplete, not in left bar

[MathMan05]

that merge should not fix this, as the channel does exist

[MathMan05]

did not mean to close

[Robocat999]

that merge should not fix this, as the channel does exist

My apologies, I misunderstood the merges change. I read it as attempting to go to a channel which fails to resolve will fallback to the @me link, which while the merge was for a different reason, seemingly would solve the reload issue all the same. I will do my best to refine my understanding of the codebase and any given merge before making any similar comments in the future.

i only saw hidden channels in autocomplete, not in left bar

How odd, I made sure to reload after each role change and to double check. Even now, I can create a new server and follow the steps to produce the issue. I'll attach screenshots showing my side by side views. Two details I realize I have left out of reproduction:

1. You must reload after applying the role, or go to another server then come back to the one with the issue. Any action that would make role changes appear.
2. To get the category to hide ( and thus be able to make it appear when it should not ) you must also set it so that the user is denied viewing permission of it by default. This does not impact the channel's appearance.

I apologize for missing the first step in particular, as the issue will not appear whatsoever without it. As roles do not show changes without a reload of the page, I've been in the habit of doing it every time I change a role, and I did not consider that action as such. I will better detail my steps should I open any further issues.
If you have already accounted for the missing step, I am unable to ascertain why we would get different results. The attached results are on a fresh server, and I had no trouble reproducing them several times over.

[MathMan05]

What are the guild level perms for the new role?

[MathMan05]

Oh wait, I see the issue

[MathMan05]

Ok, just pushed ca3e38a
see if that fixes it

[Robocat999]

I can no longer produce the issue, and the side effect of an infinite reconnect also no longer occurs. All issues appear resolved.

[MathMan05]

I'm glad!