Alphabetically Sort SOCIALS List for Improved User Experience - #8270
Alphabetically Sort SOCIALS List for Improved User Experience#8270pisum-sativum wants to merge 12 commits into
Conversation
…nt timeout on large repos
|
@pisum-sativum is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses issue #6501 by ensuring that the SOCIALS list is sorted alphabetically, making it easier for users to find their desired platform. This aligns with previous decisions aimed at improving user experience, such as fixing theme rendering based on system preferences and ensuring social URLs are correctly formatted. Thank you for your contribution, and I look forward to your updates! |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the generator UI’s socials selection experience by exporting the SOCIALS registry in alphabetical order, making the platform grid easier to scan.
Changes:
- Alphabetically sorts the exported
SOCIALSarray byname. - Adjusts
MAX_ACTION_PAGESin CI analytics fetching (note: unrelated to the PR’s stated scope).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/generator/data/socials.ts | Sorts the exported socials registry alphabetically to improve UI scanning. |
| services/github/ci-analytics.ts | Changes pagination limit for GitHub Actions analytics fetching (scope mismatch with PR goal). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const GITHUB_REST_URL = 'https://api.github.com'; | ||
| const MAX_REPO_PAGES = 2; | ||
| const MAX_ACTION_PAGES = 2; | ||
| const MAX_ACTION_PAGES = 1; | ||
| const MAX_FETCH_TARGETS = 5; |
| placeholder: 'e.g. https://huggingface.co/yourname', | ||
| }, | ||
| ]; | ||
| ].sort((a, b) => a.name.localeCompare(b.name)); |
| placeholder: 'e.g. https://huggingface.co/yourname', | ||
| }, | ||
| ]; | ||
| ].sort((a, b) => a.name.localeCompare(b.name)); |
|
@JhaSourav07 @Aamod007 I have done the necessary changes kindly check and merge with appropriate labels. |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for adding alphabetical sorting to the SOCIALS list! This is a great user experience improvement.
However, it looks like this PR includes an unrelated change to \services/github/ci-analytics.ts.
To fix this, please revert the changes to \ci-analytics.ts\ using \git checkout\ or \git restore\ so that this PR is focused entirely on the socials sorting.
Looking forward to getting this merged once the branch is cleaned up!
Label Justification:
- \level:intermediate: Assigned based on 2 files changed.
- \ ype:feature: Improves the UI by organizing the socials list alphabetically.
- \mentor:Aamod007: Assigned as required.
|
🚨 Hey @pisum-sativum, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
be3ac67 to
c081574
Compare
@Aamod007 I have done the necessary changes required but the CI is failing again and again I tried to fix it but I don't think so I can. Maybe after sometime will try ;( |
Aamod007
left a comment
There was a problem hiding this comment.
The sorting is done and the SOCIALS list is now alphabetical. The change to wrap the array in parentheses for type safety is correct. However, CI is still failing — please check the logs and resolve.
One thing to note: the PR also carries changes from other PRs (InteractiveViewer.tsx, BurnoutRiskTable.tsx, types/achievements.ts) that seem to be formatting-only or from a shared base. Could you verify your branch is based on the latest main to avoid carrying unrelated changes?
Label verification:
- level:intermediate — large file restructuring (600+ line reorder) with type wrapping logic
- quality:clean — clean
- type:feature — UX improvement via sorted list
- mentor:Aamod007 — assigned
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing: the only CI failure was Vercel authorization (not code-related). All code checks pass. The Vercel deploy auth is a repo-level config issue. Approving.
|
@Aamod007 @JhaSourav07 Kindly check and merge if possible with correct labels. |
|
@Aamod007 @JhaSourav07 Kindly merge this pr so that i can take up new issues since the bots is not allowing me to take up any more new issues . |
|
@Aamod007 @JhaSourav07 If no change is required then kindly check and merge. |
|
@Aamod007 @JhaSourav07 Pls check and merge |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod007
left a comment
There was a problem hiding this comment.
Excellent work addressing the GitHub GraphQL rate limit issues and token exposure vulnerabilities! Fixing the abort signal deduplication logic ensures we don't accidentally exhaust our rate limits under concurrent load, and gracefully sanitizing the fetch errors prevents token leaks. Approved!
|
@Aamod007 @JhaSourav07 Pls merge this pr asap |
|
@JhaSourav07 Pls merge the prs asap because i have to resolve the merge conflict again and again. |
|
@Aamod007 @JhaSourav07 Pls merge this pr asap |
|
@JhaSourav07 could you please merge all the PRs I've worked on? I've been requesting this for several days now but they are still pending. I would really appreciate it if you could review and merge them as soon as possible. Thank you! |
|
@JhaSourav07 Can u pls merge this pr |
|
@JhaSourav07 @Aamod007 pls merge the prs i have worked on pls |



Description
Fixes #6501
Automatically sorts the
SOCIALSlist alphabetically by platform name before it is exported. When this list is mapped over to render the UI selection grid, the alphabetical sorting makes it significantly easier for users to quickly scan and find their desired platform (e.g., 'CodePen' or 'Snapchat') without having to read through the entire list manually.Pillar
Visual Preview
(No visual changes to the design itself, but the dropdown order of socials is now alphabetized)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.