Delete AbelianGradedArray, leaving FusionArray as the sole graded array - #245
Merged
Conversation
Removes `AbelianGradedArray` so `FusionArray` is the single graded array for both abelian and non-abelian sectors, re-homing the shared construction and `project` surface to `gradedconstructors.jl`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 task
Matrix operations (`*`, `adjoint`, `tr`, `one!`, factorizations, matrix functions) are defined only on the matrix storage types (`FusedGradedMatrix`, `FusedSectorMatrix`, `SectorIdentity`) and error on the array types, instead of scalar-indexing through generic fallbacks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removes the `tr(::AbstractGradedMatrix)` method so `tr` on a graded array errors through the matrix-op guard instead of the block path. `tr` stays defined on the matrix storage types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 81.36% 82.27% +0.90%
==========================================
Files 30 30
Lines 2555 2279 -276
==========================================
- Hits 2079 1875 -204
+ Misses 476 404 -72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`contraction_twist!`'s docstring linked `twist!` with `@ref`, but `twist!` has no docstring, so Documenter could not resolve the cross-reference and the docs build failed. Use a plain code span instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
AbelianGradedArraysoFusionArrayis the single graded array for both abelian and non-abelian sectors, moving the shared construction andprojectmethods intogradedconstructors.jl. Matrix operations are now defined only on the matrix storage types and error on the array types.