From 588c640f9f4aa46fae4aface9da80ad31cb0c110 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 17 Apr 2026 13:10:37 +0200 Subject: [PATCH 1/9] fix bug & add tests (#739) --- ...3.variability.featuremodel.base.editor.mps | 6 +- ...ability.featuremodel.base.editor@tests.mps | 85 +++++++++++++++++++ 2 files changed, 88 insertions(+), 3 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index fb6b9e4859..9361c7c200 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -5499,9 +5499,9 @@ - - - + + + diff --git a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps index c9603b501b..86eb5ee9d2 100644 --- a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps @@ -18,6 +18,9 @@ + + + @@ -56,6 +59,12 @@ + + + + + + @@ -1552,5 +1561,81 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 140ccdb756eb31c1c03a83986b8057e67ae62737 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 12 Jun 2026 11:56:29 +0200 Subject: [PATCH 2/9] Fix: Type ':' at Feature to get FeatureModelInclude (#739) --- ...3.variability.featuremodel.base.editor.mps | 34 ++++---- ...ability.featuremodel.base.editor@tests.mps | 78 +++++++++++++++++++ 2 files changed, 92 insertions(+), 20 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index 9361c7c200..87acf560b3 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -7056,29 +7056,9 @@ - - - - - - - - - - - - - - - - - - - - @@ -7222,6 +7202,20 @@ + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps index 86eb5ee9d2..9fb9af3d62 100644 --- a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps @@ -38,6 +38,9 @@ + + + @@ -1637,5 +1640,80 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From d2722e0a229d76744d000e768deda8993ce5493b Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 12 Jun 2026 12:24:38 +0200 Subject: [PATCH 3/9] Fix: Type ':' at Feature with Cardinality to get FeatureModelInclude (#739) --- ...3.variability.featuremodel.base.editor.mps | 184 ++++++++++++++++-- ...variability.os.sandbox.notpresentvalue.mps | 16 ++ ...ability.featuremodel.base.editor@tests.mps | 45 +++++ 3 files changed, 231 insertions(+), 14 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index 87acf560b3..342fe8735a 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -49,9 +49,9 @@ + - @@ -7166,27 +7166,40 @@ - - - - - + + + + + + + + + + - - + + + + + + + + + + - - - - + + + - - + + + @@ -7216,6 +7229,149 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps index c99d2b0c61..6ac8773751 100644 --- a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps +++ b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps @@ -30,6 +30,7 @@ + @@ -134,6 +135,21 @@ + + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps index 9fb9af3d62..13ef629921 100644 --- a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps @@ -1715,5 +1715,50 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 9aa2d1dba2c4d6d9264ccf97d348e692d2bbb576 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 12 Jun 2026 12:40:08 +0200 Subject: [PATCH 4/9] Refactor common code to method (#739) --- ...3.variability.featuremodel.base.editor.mps | 267 ++++++++---------- 1 file changed, 111 insertions(+), 156 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index 342fe8735a..f1d8a63914 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -469,6 +469,7 @@ + @@ -7062,84 +7063,11 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + @@ -7232,84 +7160,11 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + @@ -9198,5 +9053,105 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 9e2584e5c86cc45da27f3a85ef7474b7c2e2f6ab Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 12 Jun 2026 13:08:06 +0200 Subject: [PATCH 5/9] Fix Test (#739) --- .../models/org.iets3.variability.featuremodel.base.editor.mps | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index f1d8a63914..eaca5fddc7 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -7057,6 +7057,7 @@ + @@ -7124,7 +7125,7 @@ - + From 127773eb8036f12c230f568f0a4d5fb87d212f44 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Fri, 12 Jun 2026 15:04:07 +0200 Subject: [PATCH 6/9] migrate (#739) --- .../models/org.iets3.variability.featuremodel.base.editor.mps | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps index eaca5fddc7..bf6f38b846 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.editor.mps @@ -7146,7 +7146,7 @@ - + From c2d4094c4ad79fa78e76392d42d5d08f6afb81b6 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Mon, 15 Jun 2026 08:44:08 +0200 Subject: [PATCH 7/9] Add Editortest typing cardinality bracket before semicolon (#739) --- ...variability.os.sandbox.notpresentvalue.mps | 8 +++- ...ability.featuremodel.base.editor@tests.mps | 42 ++++++++++++++++++- 2 files changed, 46 insertions(+), 4 deletions(-) diff --git a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps index 6ac8773751..3e4e322a43 100644 --- a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps +++ b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps @@ -63,6 +63,9 @@ + + + @@ -139,13 +142,14 @@ - + - + + diff --git a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps index 13ef629921..d14c05bbcb 100644 --- a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps @@ -1678,7 +1678,7 @@ - + @@ -1716,7 +1716,7 @@ - + @@ -1760,5 +1760,43 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From de5b827700c51d8f26d45628d8587ab261c131a1 Mon Sep 17 00:00:00 2001 From: dbinkele Date: Mon, 15 Jun 2026 10:20:53 +0200 Subject: [PATCH 8/9] migrate (#739) --- ...variability.os.sandbox.notpresentvalue.mps | 2 +- ...ability.featuremodel.base.editor@tests.mps | 42 +------------------ 2 files changed, 3 insertions(+), 41 deletions(-) diff --git a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps index 3e4e322a43..bbe6791be9 100644 --- a/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps +++ b/code/languages/org.iets3.opensource/solutions/org.iets3.variability.os.sandbox/models/org.iets3.variability.os.sandbox.notpresentvalue.mps @@ -149,7 +149,7 @@ - + diff --git a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps index d14c05bbcb..13ef629921 100644 --- a/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.org.iets3.variability.featuremodel.base/models/test.org.iets3.variability.featuremodel.base.editor@tests.mps @@ -1678,7 +1678,7 @@ - + @@ -1716,7 +1716,7 @@ - + @@ -1760,43 +1760,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - From cbf9d9aebf4270eff5605c22174e72e628503c3c Mon Sep 17 00:00:00 2001 From: Klaus Birken Date: Tue, 30 Jun 2026 13:25:07 +0200 Subject: [PATCH 9/9] Fix shortcomings of old Change-To behavior and update CHANGELOG (#739). --- CHANGELOG.md | 1 + ...riability.featuremodel.base.intentions.mps | 105 ++++++++++++++++++ 2 files changed, 106 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c70a52755..06562cf27b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ The project does _not_ follow Semantic Versioning and the changes are documented ### Fixed +- Variability: The editing of feature models in tree layout has been improved. E.g., typing ENTER on a feature will create a new sibling. Typing ":" in a feature's name will change it to a feature model include node. The intentions "Change to feature / feature model include" previously lost information about the feature, this is also fixed. - Variability: Fix workaround for using for-all-variants checking rules outside the IDE (e.g., on a build server). Due to MPS-34340, the for-all-variants checking cannot be done outside the IDE if the model under check has more than one root nodes. This bugfix includes roots of LogicalChildren in the list of used root nodes. - Physical units (language `org.iets3.core.expr.typetags.physunits`): Update unit in typesystem after prefix has been removed (e.g., from "cm" to "m"). diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps index 2f89fcd3f2..8f8d32f60f 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.variability.featuremodel.base/models/org.iets3.variability.featuremodel.base.intentions.mps @@ -460,6 +460,7 @@ + @@ -1653,6 +1654,110 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +