Rework Maglinks #141
Description
Related to the long-chain of issue #90 but not directly.
As a primer:
We use magic links to escalate user privileges and reset user passwords.
For privilege escalation, all users are sent to the hackru.org website even if they do not have an account. This leads to the weird behavior where they have to click "create account" and fill out the necessary info after which their privileges are given. That is what #90 relates to.
As for the new issue:
Both send a magic link via Sparkpost. During this hackathon, we had the unfortunate realization that Sparkpost returning 200 does not mean the email was sent, just that we provided valid information, the information can fail later with a "Generation Failure" error. This error has resulted in people not really receiving emails even though LCS says the email has been sent and a large amount of general confusion.
This has been dealt with for the current hackathon by using a script to update privileges but we need to reconsider this format for magic links. This likely would involve using a different email service besides Sparkpost and potentially considering other methods for user privilege escalation. We will likely have to coordinate with the frontend (@shivanmodha ).