ci: fix CI builds (#13)

* fix: close and minimize buttons not being perfectly the same across forms

* ci: update actions versions

* style: add missing tab

* refactor: reduce indentation in SendFunkeyViaMB()

Author: NanderTGA

.github/workflows/nightly.yml

@@ -28,17 +28,17 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup MSBuild
-        uses: microsoft/setup-msbuild@v1
+        uses: microsoft/setup-msbuild@v2
 
       - name: Setup NuGet
-        uses: NuGet/setup-nuget@v1
+        uses: NuGet/setup-nuget@v2
 
       - name: Restore Packages
         run: nuget restore ${{ env.solutionFile }}
 
       - name: Get version from update.xml
         id: getVersion
-        uses: mavrosxristoforos/get-xml-info@1.2.1
+        uses: mavrosxristoforos/get-xml-info@2.0
         with:
           xml-file: update.xml
           xpath: //update/@version
@@ -61,7 +61,7 @@ jobs:
         run: msbuild ${{ env.solutionFile }} -t:rebuild -property:Configuration=${{ matrix.configuration }}
 
       - name: Upload the build results as an artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: ${{ env.projectFolder }}/bin/${{ matrix.configuration }}/*
           name: ${{ env.projectName }}.Nightly.${{ matrix.configuration }}

.github/workflows/release.yml

@@ -34,17 +34,17 @@ jobs:
           git config user.email "<>"
       
       - name: Setup MSBuild
-        uses: microsoft/setup-msbuild@v1
+        uses: microsoft/setup-msbuild@v2
 
       - name: Setup NuGet
-        uses: NuGet/setup-nuget@v1
+        uses: NuGet/setup-nuget@v2
 
       - name: Restore Packages
         run: nuget restore ${{ env.solutionFile }}
 
       - name: Get version from release name
         id: version
-        uses: mad9000/actions-find-and-replace-string@4
+        uses: mad9000/actions-find-and-replace-string@5
         with:
           source: "${{ github.event.release.tag_name }}"
           find: "v"
@@ -68,7 +68,7 @@ jobs:
         run: msbuild ${{ env.solutionFile }} -t:rebuild -property:Configuration=${{ matrix.configuration }}
 
       - name: Upload the build results as an artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: ${{ env.projectFolder }}/bin/${{ matrix.configuration }}/*
           name: ${{ env.projectName }}.${{ github.event.release.tag_name }}.${{ matrix.configuration }}

FunkeySelector/CustomFManager.cs

@@ -70,34 +70,34 @@ public static void SendFunkeyViaMB(string funkeyID)
             if (gamePtr == IntPtr.Zero)
             {
                 MessageBox.Show("There is no instance of U.B. Funkeys currently running.", "FunkeySelectorGUI", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                return;
             }
-            else
+
+            IntPtr ptrCopyData = IntPtr.Zero;
+            try
             {
-                IntPtr ptrCopyData = IntPtr.Zero;
-                try
+                COPYDATASTRUCT copyData = new()
                 {
-                    COPYDATASTRUCT copyData = new COPYDATASTRUCT
-                    {
-                        dwData = new IntPtr(238164658), //A strange data type that's required for the game to switch the Bitty.
-                        cbData = idtosend.Length + 1,
-                        lpData = Marshal.StringToHGlobalAnsi(idtosend)
-                    };
+                    dwData = new IntPtr(238164658), // A strange data type that's required for the game to switch the Bitty.
+                    cbData = idtosend.Length + 1,
+                    lpData = Marshal.StringToHGlobalAnsi(idtosend)
+                };
 
-                    ptrCopyData = Marshal.AllocCoTaskMem(Marshal.SizeOf(copyData));
-                    Marshal.StructureToPtr(copyData, ptrCopyData, false);
+                ptrCopyData = Marshal.AllocCoTaskMem(Marshal.SizeOf(copyData));
+                Marshal.StructureToPtr(copyData, ptrCopyData, false);
 
-                    SendMessage(gamePtr, WM_COPYDATA, IntPtr.Zero, ptrCopyData);
-                }
-                catch (Exception ex)
-                {
-                    MessageBox.Show(ex.ToString(), "FunkeySelectorGUI", MessageBoxButtons.OK, MessageBoxIcon.Error);
-                }
-                finally
-                {
-                    if (ptrCopyData != IntPtr.Zero)
-                        Marshal.FreeCoTaskMem(ptrCopyData);
-                }
+                SendMessage(gamePtr, WM_COPYDATA, IntPtr.Zero, ptrCopyData);
+            }
+            catch (Exception ex)
+            {
+                MessageBox.Show(ex.ToString(), "FunkeySelectorGUI", MessageBoxButtons.OK, MessageBoxIcon.Error);
+            }
+            finally
+            {
+                if (ptrCopyData != IntPtr.Zero)
+                    Marshal.FreeCoTaskMem(ptrCopyData);
             }
+            
         }
     }
 }