fix

Author: ins426

lib/files/src/SettingsXml.ts

@@ -206,7 +206,7 @@ export class SettingsXml extends XmlFileWithContentTypes {
 						attribute ${QNS.r}id { $attachedTemplate }
 					} else (),
 					if (exists($documentProtection)) then element ${QNS.w}documentProtection {
-						attribute ${QNS.w}edit { $documentProtection('edit')},
+						if ($documentProtection('edit')) then attribute ${QNS.w}edit { $documentProtection('edit')} else (),
 						attribute ${QNS.w}enforcement { $documentProtection('enforcement') }
 					} else (),
 					if (exists($footnoteProperties)) then (
@@ -281,9 +281,14 @@ export class SettingsXml extends XmlFileWithContentTypes {
 				"isTrackChangesEnabled": docxml:ct-on-off(./${QNS.w}trackChanges),
 				"evenAndOddHeaders": docxml:ct-on-off(./${QNS.w}evenAndOddHeaders),
 				"documentProtection": if (./${QNS.w}documentProtection) then (
-					map {
-						"edit": string(./${QNS.w}documentProtection/@${QNS.w}edit),
-						"enforcement": docxml:st-on-off(./${QNS.w}documentProtection/@${QNS.w}enforcement)
+					let $edit := string(./${QNS.w}documentProtection/@${QNS.w}edit)
+					let $enforcement := docxml:st-on-off(./${QNS.w}documentProtection/@${QNS.w}enforcement)
+					return if ($edit)
+					then map {
+						"edit": $edit,
+						"enforcement": $enforcement
+					} else map {
+						"enforcement": $enforcement
 					}
 				) else ()
 			}`,

lib/files/test/SettingsXml.test.ts

@@ -57,7 +57,7 @@ describe('SettingsXml', () => {
 			position: 'beneathText',
 		});
 	});
-	it('documentProtection', async () => {
+	it('documentProtection with edit property', async () => {
 		const settings = new SettingsXml('test');
 		expect(settings.get('documentProtection')).toBe(null);
 		settings.set('documentProtection', {
@@ -84,4 +84,28 @@ describe('SettingsXml', () => {
 			docxFromArchive.document.settings.get('documentProtection')
 		).toEqual(customSettings);
 	});
+	it('documentProtection without edit', async () => {
+		const settings = new SettingsXml('test');
+		expect(settings.get('documentProtection')).toBe(null);
+		settings.set('documentProtection', {
+			enforcement: true,
+		});
+		expect(settings.get('documentProtection')).toEqual({
+			enforcement: true,
+		});
+
+		expect(serialize(await settings.$$$toNode())).toEqual(
+			`<w:settings xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main"><w:documentProtection w:enforcement="true"/></w:settings>`
+		);
+
+		const docx = Docx.fromNothing();
+		const customSettings: DocumentProtectionProps = {
+			enforcement: false,
+		};
+		docx.document.settings.set('documentProtection', customSettings);
+		const docxFromArchive = await Docx.fromArchive(await docx.toArchive());
+		expect(
+			docxFromArchive.document.settings.get('documentProtection')
+		).toEqual(customSettings);
+	});
 });