Fixes and Updates

[DRollin]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.65%. Comparing base (1076576) to head (4a79dfc).

Files with missing lines	Patch %	Lines
src/grid.jl	91.02%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   89.29%   90.65%   +1.35%     
==========================================
  Files           5        5              
  Lines         327      353      +26     
==========================================
+ Hits          292      320      +28     
+ Misses         35       33       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DRollin]

I am not completely happy with the new way of testing, but for now this fixes #34

[DRollin]

I improved the grid tests and fixed #35
However, mixed grids are now only supported for Triangle-Quadrilateral connections.
I am not sure how to support more general interfaces, which would require a rework of the InterfaceCellValues

[termi-official]

However, mixed grids are now only supported for Triangle-Quadrilateral connections.

This is already great progress!

I am not sure how to support more general interfaces, which would require a rework of the InterfaceCellValues

What is the blocker here? We can also leave this for later if this is a bigger todo.

[termi-official]

I think you still need to pass information about which local facet is used to support pyramids+wedges.

[DRollin]

I used the number of nodes on one face as a criterion instead.
The nodes were past to the function one layer up anyway and should be usable independent of the cell types.
I only added a very basic test, but it seems to be working for pyramids and wedges.

[DRollin]

However, mixed grids are now only supported for Triangle-Quadrilateral connections.

This is already great progress!

I am not sure how to support more general interfaces, which would require a rework of the InterfaceCellValues

What is the blocker here? We can also leave this for later if this is a bigger todo.

Currently, the InterfaceCellValues use the same type of underlying CellValues on both sides.
For more general interfaces, we would have to allow for two different types of CellValues.
In my very first version, that was allowed and we had a long discussion about it and agreed to rather simplify things.

[DRollin]

This should now also solve #39
I think these are enough changes for one PR and it could be merged.

[termi-official]

Note that the 1.10 CI is failing.