Skip to content

Fix VTK export - #37

Merged
DRollin merged 8 commits into
mainfrom
do/fix-vtk-export
Jul 6, 2026
Merged

Fix VTK export#37
DRollin merged 8 commits into
mainfrom
do/fix-vtk-export

Conversation

@termi-official

Copy link
Copy Markdown
Member

No description provided.

@termi-official
termi-official requested a review from DRollin July 2, 2026 20:51
@termi-official termi-official linked an issue Jul 2, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.29%. Comparing base (17919d5) to head (d92fbc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   88.60%   89.29%   +0.68%     
==========================================
  Files           5        5              
  Lines         316      327      +11     
==========================================
+ Hits          280      292      +12     
+ Misses         36       35       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/cells.jl Outdated
@termi-official
termi-official marked this pull request as draft July 6, 2026 09:46
@DRollin

DRollin commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

I just saw that you also fixed a few other things than just the VTK issue.
Over the next few days, I want to spend some time on resolving general issues.
Do you think this PR is ready to be merged or can I do something to finish things up?
(I would like to fin ish this before starting other things)

@termi-official
termi-official marked this pull request as ready for review July 6, 2026 11:18
@termi-official

Copy link
Copy Markdown
Member Author

I just saw that you also fixed a few other things than just the VTK issue.

Yes, I also updated the CI to the new versions. Other than that the PR only fixes the VTK export machinery. The PR is now ready from my side and targets current master again.

@DRollin
DRollin merged commit 1076576 into main Jul 6, 2026
5 of 6 checks passed
@DRollin
DRollin deleted the do/fix-vtk-export branch July 6, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VTK export broken

2 participants