Skip to content

Add Ferrite.jl's old default edge and face dof indices functions - #33

Merged
KnutAM merged 5 commits into
mainfrom
kam/edgefacedof_indices
Mar 17, 2026
Merged

Add Ferrite.jl's old default edge and face dof indices functions#33
KnutAM merged 5 commits into
mainfrom
kam/edgefacedof_indices

Conversation

@KnutAM

@KnutAM KnutAM commented Mar 9, 2026

Copy link
Copy Markdown
Member

This is a workaround for #32 to make FerriteInterfaceElements.jl unaffected by new default implementations in Ferrite-FEM/Ferrite.jl#1293. #32 is not closed by this, since it does seem like the current implementation is incorrect (but this PR doesn't change the current implementation).

@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.69%. Comparing base (42da30d) to head (db5053c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   88.61%   88.69%   +0.08%     
==========================================
  Files           5        5              
  Lines         281      283       +2     
==========================================
+ Hits          249      251       +2     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KnutAM

KnutAM commented Mar 10, 2026

Copy link
Copy Markdown
Member Author
- addcellset!(grid, "bottom", Set((1,2,3,4)))
+ addcellset!(grid, "bottom", OrderedSet((4, 2, 3, 1)))

The change in order was done by creating the old Set (which passes tests on v11), and checking the created OrderedSet with getcellset, which had a different order. The two other sets kept their order, so changed only to using OrderedSet to guarantee keeping this order.

Edit: Same for 3d

Edit2: Didn't seem to work, unrelated to this PR so opening issue instead.

@KnutAM
KnutAM merged commit 90dbb7c into main Mar 17, 2026
3 of 5 checks passed
@KnutAM
KnutAM deleted the kam/edgefacedof_indices branch March 17, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant