fix: expose 8 hidden OCPP 1.6 config keys via GetConfiguration#1817
Closed
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
Closed
fix: expose 8 hidden OCPP 1.6 config keys via GetConfiguration#1817rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
Conversation
Add missing KeyValue methods and dispatch entries for EnableTLSKeylog, LogRotation, LogRotationDateSuffix, LogRotationMaximumFileCount, LogRotationMaximumFileSize, TLSKeylogFile, UseTPM, and UseTPMSeccLeafCertificate in ChargePointConfiguration::get(). These keys could be set locally but were not retrievable by the CSMS because they were missing from the get() dispatch chain. Closes EVerest#1796 Signed-off-by: Rishabh Vaish <rishabhvaish.904@gmail.com>
Contributor
|
Hi @rishabhvaish , thanks for the contribution! We are closing this PR in favor of #1801, in which work for this issue started just a little bit earlier. |
Contributor
Author
|
Thanks for letting me know @Pietfried! No worries at all — glad the issue is being addressed in #1801. Happy to keep contributing on other issues! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyValuewrapper methods forEnableTLSKeylog,TLSKeylogFile,UseTPM, andUseTPMSeccLeafCertificateacross the interface and both implementationsChargePointConfiguration::get()for all affected keysreadonly = true(internal config, not CSMS-settable)Root Cause
The
get()method uses an if-chain to dispatch key lookups toKeyValuemethods. These 8 keys had getter methods but were missing from the dispatch chain, making them invisible to the CSMS viaGetConfiguration.Files Changed (5)
charge_point_configuration_interface.hppKeyValuedeclarationscharge_point_configuration.hppcharge_point_configuration_devicemodel.hppcharge_point_configuration.cppKeyValuemethod implementations + 8 if-statements inget()charge_point_configuration_devicemodel.cppKeyValuemethod implementationsTest Plan
cmake)ctest -R test_configuration)GetConfigurationreturns values for all 8 keysCloses #1796