Skip to content

fix: expose 8 hidden OCPP 1.6 config keys via GetConfiguration#1817

Closed
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
rishabhvaish:fix/issue-1796-hidden-ocpp16-config-keys
Closed

fix: expose 8 hidden OCPP 1.6 config keys via GetConfiguration#1817
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
rishabhvaish:fix/issue-1796-hidden-ocpp16-config-keys

Conversation

@rishabhvaish
Copy link
Copy Markdown
Contributor

Summary

  • Add KeyValue wrapper methods for EnableTLSKeylog, TLSKeylogFile, UseTPM, and UseTPMSeccLeafCertificate across the interface and both implementations
  • Add 8 missing if-statements in ChargePointConfiguration::get() for all affected keys
  • All keys marked readonly = true (internal config, not CSMS-settable)

Root Cause

The get() method uses an if-chain to dispatch key lookups to KeyValue methods. These 8 keys had getter methods but were missing from the dispatch chain, making them invisible to the CSMS via GetConfiguration.

Files Changed (5)

File Change
charge_point_configuration_interface.hpp 4 new pure virtual KeyValue declarations
charge_point_configuration.hpp 4 new override declarations
charge_point_configuration_devicemodel.hpp 4 new override declarations
charge_point_configuration.cpp 4 KeyValue method implementations + 8 if-statements in get()
charge_point_configuration_devicemodel.cpp 4 KeyValue method implementations

Test Plan

  • Build passes (cmake)
  • Existing unit tests pass (ctest -R test_configuration)
  • Manual: OCPP 1.6 GetConfiguration returns values for all 8 keys

Closes #1796

Add missing KeyValue methods and dispatch entries for EnableTLSKeylog,
LogRotation, LogRotationDateSuffix, LogRotationMaximumFileCount,
LogRotationMaximumFileSize, TLSKeylogFile, UseTPM, and
UseTPMSeccLeafCertificate in ChargePointConfiguration::get().

These keys could be set locally but were not retrievable by the CSMS
because they were missing from the get() dispatch chain.

Closes EVerest#1796

Signed-off-by: Rishabh Vaish <rishabhvaish.904@gmail.com>
@Pietfried
Copy link
Copy Markdown
Contributor

Hi @rishabhvaish , thanks for the contribution! We are closing this PR in favor of #1801, in which work for this issue started just a little bit earlier.

@Pietfried Pietfried closed this Feb 16, 2026
@rishabhvaish
Copy link
Copy Markdown
Contributor Author

Thanks for letting me know @Pietfried! No worries at all — glad the issue is being addressed in #1801. Happy to keep contributing on other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden OCPP1.6 Configuration Keys

2 participants