fix: adding missing OCPP1.6 Configuration Keys (#1796)#1801
Merged
Pietfried merged 1 commit intoEVerest:mainfrom Feb 19, 2026
Merged
fix: adding missing OCPP1.6 Configuration Keys (#1796)#1801Pietfried merged 1 commit intoEVerest:mainfrom
Pietfried merged 1 commit intoEVerest:mainfrom
Conversation
ThatsLucas
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
ThatsLucas
force-pushed
the
hidden-ocpp-v16
branch
from
7fed90d to
b9e8eb8
Compare
Contributor
|
Hi @ThatsLucas , thanks for the contribution! The changes look good. Unfortunately 0a2c98d introduced conflicts. Can you rebase and resolve it? Please make sure you squash your commits into one. |
ThatsLucas
force-pushed
the
hidden-ocpp-v16
branch
from
b9e8eb8 to
5836c2b
Compare
Contributor
Author
|
Hello @Pietfried, done, tell me if anything is wrong :) |
ThatsLucas
force-pushed
the
hidden-ocpp-v16
branch
from
f116f30 to
8abb7c6
Compare
Contributor
Author
|
Im not sure whats wrong with the unit tests |
Contributor
You can download the ctest-report artifact from https://github.com/EVerest/everest-core/actions/runs/21981574665?pr=1801 or alternatively run the unit tests locally. Feel free to let us know if you need help with analyzing the issue. |
ThatsLucas
force-pushed
the
hidden-ocpp-v16
branch
from
8abb7c6 to
7972144
Compare
Contributor
Author
|
As I understand it, the tests were previously expecting these keys not to return any value. Please let me know if this interpretation is incorrect or if further changes are needed. |
james-ctc
requested changes
Feb 13, 2026
…::get() Fixes EVerest#1796. Expose configuration keys that were configurable locally but not retrievable via OCPP 1.6 GetConfiguration due to missing cases in ChargePointConfiguration::get(). Signed-off-by: ThatsLucas <lucasmailpro9@gmail.com> v16: add missing KeyValue getters in device model Sorry, I forgot to implement the new interface methods. This adds the missing TLS keylog and TPM KeyValue getters to keep the device model in sync with ChargePointConfigurationInterface. Signed-off-by: ThatsLucas <lucasmailpro9@gmail.com> Changed test_custom.cpp to add tests for the new hidden keys. Updated known_keys.cpp to include the new hidden keys. Updated charge_point_configuration_devicemodel.cpp to handle the new hidden keys in get() and set() methods. Updated charge_point_configuration_interface.hpp to declare the new hidden keys. Made the change requested by james-ctc. It is now complient with the existing standard. Changed Read only check order in test_custom.cpp. Signed-off-by: ThatsLucas <lucasmailpro9@gmail.com>
ThatsLucas
force-pushed
the
hidden-ocpp-v16
branch
from
7972144 to
9734887
Compare
Pietfried
approved these changes
Feb 16, 2026
3 tasks
Pietfried
added
the
include-in-release
3 tasks
Dalachowsky
pushed a commit
to Dalachowsky/everest-core
that referenced
this pull request
Feb 20, 2026
…::get() (EVerest#1801) Fixes EVerest#1796. Expose configuration keys that were configurable locally but not retrievable via OCPP 1.6 GetConfiguration due to missing cases in ChargePointConfiguration::get(). v16: add missing KeyValue getters in device model Sorry, I forgot to implement the new interface methods. This adds the missing TLS keylog and TPM KeyValue getters to keep the device model in sync with ChargePointConfigurationInterface. Changed test_custom.cpp to add tests for the new hidden keys. Updated known_keys.cpp to include the new hidden keys. Updated charge_point_configuration_devicemodel.cpp to handle the new hidden keys in get() and set() methods. Updated charge_point_configuration_interface.hpp to declare the new hidden keys. Made the change requested by james-ctc. It is now complient with the existing standard. Changed Read only check order in test_custom.cpp. Signed-off-by: ThatsLucas <lucasmailpro9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCPP 1.6: add missing configuration keys to ChargePointConfiguration::get()
Fixes #1796.
Expose configuration keys that were configurable locally but not retrievable via OCPP 1.6 GetConfiguration due to missing cases in ChargePointConfiguration::get().
Describe your changes
Issue ticket number and link
#1796
Checklist before requesting a review