Future Improvements for Windows Installer
Follow-up items identified during PR #3 review that are non-blocking but worth tracking for future work.
1. Add Application Icon
- The
icon.ico is currently disabled in installer/Package.wxs
- Need to create/add a proper PinShare icon file
- Update Package.wxs to enable icon references (lines 52-54, 190-197)
2. Automatic Firewall Rules
- Consider adding automatic Windows Firewall rule creation during install for P2P ports:
- Port 4001 (TCP/UDP) - IPFS Swarm
- Port 50001 (TCP) - PinShare libp2p
- Could use
netsh advfirewall or WiX Firewall extension
3. Installer-Generated config.json
- Currently the installer writes to Windows Registry (
HKLM\SOFTWARE\PinShare) but the service reads from config.json
- Options:
- Remove registry writes from installer (they appear unused), OR
- Have installer generate initial
config.json with user-provided values from the config dialog
4. Hardcoded Ports in Tray App
cmd/pinshare-tray/tray.go has hardcoded ports for health checks (lines 411, 427)
- Should read from config file for consistency with user-configured ports
Identified during review of PR #3
Future Improvements for Windows Installer
Follow-up items identified during PR #3 review that are non-blocking but worth tracking for future work.
1. Add Application Icon
icon.icois currently disabled ininstaller/Package.wxs2. Automatic Firewall Rules
netsh advfirewallor WiX Firewall extension3. Installer-Generated config.json
HKLM\SOFTWARE\PinShare) but the service reads fromconfig.jsonconfig.jsonwith user-provided values from the config dialog4. Hardcoded Ports in Tray App
cmd/pinshare-tray/tray.gohas hardcoded ports for health checks (lines 411, 427)Identified during review of PR #3