Skip to content

ACL refactors: Unindent some code and functionize unpacking permission #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clumens merged 21 commits into from
Jan 28, 2026
+256 −221
Merged

ACL refactors: Unindent some code and functionize unpacking permission #4035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
48946fa
Refactor: libcrmcommon: Unindent a block in xml_acl_filtered_copy()
nrwahl2 Dec 25, 2025
f293036
Refactor: libcrmcommon: Rename some variables in xml_acl_filtered_copy()
nrwahl2 Dec 25, 2025
2c7c8ee
Refactor: libcrmcommon: Drop some NULL checks in xml_acl_filtered_copy()
nrwahl2 Jan 27, 2026
894bcdb
Refactor: libcrmcommon: Use g_clear_pointer() in xml_acl_filtered_copy()
nrwahl2 Jan 27, 2026
61a9ca8
Refactor: libcrmcommon: Unindent another block of xml_acl_filtered_copy
nrwahl2 Dec 25, 2025
141fb9f
Refactor: libcrmcommon: pcmk__xe_first_child() in purge_xml_attributes()
nrwahl2 Dec 25, 2025
61fe1f0
Refactor: libcrmcommon: Drop xIter in purge_xml_attributes()
nrwahl2 Dec 25, 2025
8ee4094
Refactor: libcrmcommon: Functionize applying a single ACL
nrwahl2 Dec 25, 2025
e74074f
Refactor: libcrmcommon: Create GString unconditionally in apply_acl()
nrwahl2 Dec 25, 2025
2bbab91
Refactor: libcrmcommon: Use const in pcmk__apply_acls()
nrwahl2 Dec 25, 2025
dbad067
Refactor: libcrmcommon: pcmk__apply_acls() takes an xmlDoc *
nrwahl2 Dec 25, 2025
3abe51e
Refactor: libcrmcommon: pcmk__xpath_foreach_result in pcmk__apply_acls
nrwahl2 Dec 25, 2025
9bbe4aa
Refactor: libcrmcommon: Assert arg not NULL in pcmk__unpack_acl()
nrwahl2 Dec 25, 2025
66814c9
Refactor: libcrmcommon: Reduce duplication in pcmk__apply_acls()
nrwahl2 Dec 25, 2025
be68ef3
Refactor: libcrmcommon: Continue on NULL id in pcmk__unpack_acls()
nrwahl2 Dec 25, 2025
f57f4f3
Refactor: libcrmcommon: Reduce some duplication in pcmk__unpack_acls()
nrwahl2 Dec 25, 2025
186f845
Refactor: libcrmcommon: Unindent loop in pcmk__unpack_acls()
nrwahl2 Dec 25, 2025
71354e0
Refactor: libcrmcommon: Unindent more of pcmk__unpack_acls()
nrwahl2 Dec 25, 2025
42c1f9e
Refactor: libcrmcommon: parse_acl_entry() specifies element in iterators
nrwahl2 Dec 25, 2025
0fc264b
Refactor: libcrmcommon: Functionize unpacking ACL permission
nrwahl2 Dec 25, 2025
9d96604
Log: libcrmcommon: Set config warnings and errors for acl_permission
nrwahl2 Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading