About Ringbuffer empty

[Frank-Bemelman]

I have this Spanish station, that plays well in my webbrowser.

https://soporte.ikernet.net:6443/listen/segura_irratia/radio.mp3

But on my radioglobe it plays for a second maybe, and quits with a Ringbuffer empty.

So I did some rogue code changes, (partially) commented out two lines, left a note who did it, but no idea what I was thinking...
So now it looks like this:

void ESP32_VS1053_Stream::_chunkedStreamToRingBuffer(WiFiClient *stream)
{
    [[maybe_unused]] const auto startTimeMS = millis();
    size_t bytesToRingBuffer = 0;

    const size_t MAX_MOVE = size() ? 2048 : 512; // everything without a size is radio so low bitrate

    if (_bytesLeftInChunk 
//         && _musicDataPosition < _metaDataStart // Frank did this
         && xRingbufferGetCurFreeSize(_ringbuffer_handle) 
         && stream->available())
    { 
//        const size_t inStream = _metaDataStart ? _metaDataStart - _musicDataPosition : stream->available();
        const size_t inStream = stream->available(); // by Frank
  
        const size_t inChunk = min(_bytesLeftInChunk, inStream);
        const size_t toMove = min(inChunk, MAX_MOVE);
        const size_t toRead = min(toMove, xRingbufferGetCurFreeSize(_ringbuffer_handle));
        const size_t inBuffer = stream->read(_localbuffer, toRead);
        const BaseType_t result = xRingbufferSend(_ringbuffer_handle, _localbuffer, inBuffer, 0);
        if (result == pdFALSE)
        {
            log_v("ringbuffer failed to receive %i bytes. Closing stream.", inBuffer);
            if (_errorCallback)
                _errorCallback(ERROR_RINGBUFFER_FAIL);
            _remainingBytes = 0;
            return;
        }

        _bytesLeftInChunk -= inBuffer;
        bytesToRingBuffer += inBuffer;
        _musicDataPosition += _metaDataStart ? inBuffer : 0;
    }
    log_d("%lu ms moving %i bytes chunked->ringbuffer", millis() - startTimeMS, bytesToRingBuffer);
}

The interesting thing is, this particular station now plays happily along. But I probably also have broken something.
A quick test, running some other stations, doesn't reveal any strange new behaviour.

Just to keep you entertained eh.

[CelliesProjects]

Interesting.
I will check this out and see if I get some insight.

[CelliesProjects]

I can not test atm, but I just thought that maybe these stations might run fine without psram buffer, just as a quick check.

[Frank-Bemelman]

No rush. I just stumbled upon this one, and since 'ringbuffer empty' can have good reasons, this one looked a little different. I tried hunting down _metaDataStart and _musicDataPosition, but that is all way over my head, not to say totally clueless.

[Frank-Bemelman]

I undid all my roque changes. ESP32_VS1053_Stream::_chunkedStreamToRingBuffer(WiFiClient *stream) is back to the original.

In ESP32_VS1053_Stream::_handleChunkedStream(WiFiClient *stream) I commented out these lines.

    if (_metaDataStart && _musicDataPosition == _metaDataStart && _bytesLeftInChunk && stream->available())
    {
        const auto required = stream->peek() * 16 + 20; /* extra margin for chunk end */
//        if (stream->available() < required)
//        {
//            if (_ringbuffer_handle && _remainingBytes)
//                _playFromRingBuffer();
//            return;
//       }

        const auto metaLen = stream->read() * 16;
        _bytesLeftInChunk--;

        if (metaLen)
        {

Has the same effect, station does not quit early. Perhaps this is closer to where it goes wrong.
Still testing this with that https://soporte.ikernet.net:6443/listen/segura_irratia/radio.mp3

For what it's worth...

[Frank-Bemelman]

I can not test atm, but I just thought that maybe these stations might run fine without psram buffer, just as a quick check.

I did a compile without PSRAM enabled, but that didn't make any difference.

I have another station in Australia, https://stream.zeno.fm/0psw13g10a0uv
That is a 320kbps stream.
Plays well, in a webbrowser, but stutters a lot with the ESP32S3.

When I change, in ESP32_VS1053_Stream::_chunkedStreamToRingBuffer(WiFiClient *stream) and also in ESP32_VS1053_Stream::_handleChunkedStream(WiFiClient *stream)

//const size_t MAX_MOVE = size() ? 2048 : 512; // everything without a size is radio so low bitrate
const size_t MAX_MOVE = 4096;

..it doesn't stutter at all.

I did try to follow the flow of things, and tbh some of the parts I think I understand seem to add/subtract accurately to the last bit, so I have no clue as usual.