Cleaning after testing

[gswifort]

I think that after each test (of each function) commands and modules loaded by this function should be removed. This can be easily implemented using pytest.fixture(autouse=True) Dan, please advise what to look for when removing commands and modules (if it is at all possible).

[CEXT-Dan]

TLDR; we should consider starting new sessions, new documents instead

What is the goal? Currently, we are not setup to do this.

• If the module was explicitly loaded with loadPythonModule, I keep a reference for the session.
• might work with regCommand then removeCommand, however if the module shares a state with C++ and that module’s memory space is corrupt, then it’s undefined behavior

For testing in general, I feel it’s always wiser to start a new session for tests that require a clean memory space and/or a clean document. Currently, our test suite is under a locked document, so we can’t switch to a new fresh document, it does not make sense to unload commands or modules in this context

Ideally, a good test suite should be divided into categories

• unit tests, single session, invariant to Application/Document contexts
• long tests under a locked document
• long tests that can run in Application context
• test that have a per session flag (long)

run_tests_cmd could be launched with relevant Ap.CmdFlags

At some point we will need to test drawings + code that may crash on some platforms, and we don’t want these tests to nuke the rest of the test suite.

[gswifort]

It was just that individual tests might try to add commands/modules with the same names, especially when the same tests are executed multiple times in one session. But if it's more complicated, then there's no need to worry about it now.