NTX-Builder: tx expiration delta doesn't work with `NetworkAuth` component

[SantiagoPittella]

The ntx-builder is failing to execute transaction for accounts that uses NetworkAuth. This component requires note scripts to be whitelisted on account creation, and does not allow the execution of transactions scripts. This is causing our injected tx script for expirations to fail every time with an assertion error from the auth compnent.

Some options that I thought:

1. Modify the auth component to support expiration delta
2. Remove the enforced script injection on the ntx builder. This is not ideal because we cannot ensure that a submit transaction sent N blocks ago is not going to land eventually, but maybe we can define some certain threshold in which we are confortable so say that the transaction will not land

[igamigo]

Maybe another way to tackle this is to change the AuthNetworkAccount auth script and set the expiration delta within it directly? And then the transaction script can still be asserted to be empty. EDIT: Misread originally, but I realize that this is essentially what you outlined above.

[Mirko-von-Leipzig]

Remove the enforced script injection on the ntx builder. This is not ideal because we cannot ensure that a submit transaction sent N blocks ago is not going to land eventually, but maybe we can define some certain threshold in which we are confortable so say that the transaction will not land

Short term this is all we can do in the node I guess..

Interesting, I hadn't anticipated that expiration would be a component. I somehow always assumed it was a transaction property like its account ID.

[bobbinth]

Interesting, I hadn't anticipated that expiration would be a component. I somehow always assumed it was a transaction property like its account ID.

We need to be able to define expiration timeframes "programmatically" - i.e., based on some specifics of what the account does - so, we cannot set it purely externally.

I think there are two options (maybe more):

1. @SantiagoPittella proposed, modify the NetworkAuth component so that the auth procedure takes expiration delta as a parameter. One downside of this is that we can't guarantee that the standard network auth procedure will be used for all network accounts (i.e., users may want to define their versions of the auth procedure that meet their specific needs).
2. Add support for allowed tx scripts in the NetworkAuth component. Then, we'd require a script that sets expiration delta to be allowed on any network account (and if the account doesn't do that, we'd consider that not a network account).

Both of these changes would need to be done in the protocol though. So, maybe for now we can release the node w/o these and then update in a patch release (technically, this would be a breaking change, but not at the interface level).

[SantiagoPittella]

Ok, in the meantime I will remove the injection of the tx script and leave only the expiration check in the builder side